-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add support for error pages when loading https invalid cert #34
Comments
Good catch, this needs to be supported somehow. |
In general the we should probably support
|
This fixes my initial issue from auchenberg#34. It does not add the extra jargle in that issue. It should also be noted that with this change you should never try to hit any site you wish to be secure on. Such as you should not log into Amazon with it. I don't think that would be an issue. But people are unwise sometimes.
I think the best way would be to listen to https://chromedevtools.github.io/devtools-protocol/tot/Security#event-certificateError, and render a simple error page with the info, just like Chrome does. You would expect this of Chrome, and for a browser preview. A new power user setting could also be introduced to ignore certs, but I'd like to avoid introducing new settings/flags unless they are absolutely needed. |
Examples of all errors to implement, https://badssl.com/ |
I think it would be a great idea to have a setting that ignores HTTPS errors. I deal with self signed certs a lot in local dev, this would be a great time saver over clicking through error messages |
So I have tested this with a few different servers. When I open a page with an invalid cert (such as a self signed cert for dev) The page does not load. If I open the page in native chrome I am able to accept the security exception. But on browser-preview I get a blank page.
The text was updated successfully, but these errors were encountered: