Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add support for error pages when loading https invalid cert #34

Open
jhicken opened this issue Jan 23, 2019 · 5 comments
Open
Labels
enhancement New feature or request

Comments

@jhicken
Copy link

jhicken commented Jan 23, 2019

So I have tested this with a few different servers. When I open a page with an invalid cert (such as a self signed cert for dev) The page does not load. If I open the page in native chrome I am able to accept the security exception. But on browser-preview I get a blank page.

@auchenberg
Copy link
Owner

Good catch, this needs to be supported somehow.

@auchenberg auchenberg changed the title https invalid cert causes page to not load Add support for error pages when loading https invalid cert Jan 23, 2019
@auchenberg
Copy link
Owner

In general the we should probably support

  • Any HTTP error
  • Cert errors
  • Add Dino game? for crashes :)

@auchenberg auchenberg added the enhancement New feature or request label Jan 23, 2019
jhicken added a commit to jhicken/vscode-browser-preview that referenced this issue Jan 24, 2019
This fixes my initial issue from auchenberg#34. It does not add the extra jargle in that issue.

It should also be noted that with this change you should never try to hit any site you wish to be secure on. Such as you should not log into Amazon with it. I don't think that would be an issue. But people are unwise sometimes.
@auchenberg
Copy link
Owner

I think the best way would be to listen to https://chromedevtools.github.io/devtools-protocol/tot/Security#event-certificateError, and render a simple error page with the info, just like Chrome does. You would expect this of Chrome, and for a browser preview.

A new power user setting could also be introduced to ignore certs, but I'd like to avoid introducing new settings/flags unless they are absolutely needed.

@auchenberg
Copy link
Owner

Examples of all errors to implement, https://badssl.com/

@jccit
Copy link

jccit commented Apr 30, 2019

I think it would be a great idea to have a setting that ignores HTTPS errors. I deal with self signed certs a lot in local dev, this would be a great time saver over clicking through error messages

@auchenberg auchenberg changed the title Add support for error pages when loading https invalid cert Feature: Add support for error pages when loading https invalid cert May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants