Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 234: machine readable format for asetekpro pump #235

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

mcombell
Copy link
Contributor

Proposed changes

This commit adds support for the --machine option to the asetekpro pump so that it produces machine readable output for the values of the temperature, fans and pump.

Types of changes

What types of changes does your code introduce to OpenCorsairLink?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the testing branch (left side). Also you should start your branch off our testing.
  • [ x Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules
  • Check the commit's or even all commits' message styles matches our requested structure.

Further comments

The fix was to simply add calls to the msg_machine() method similar to what already exists in the hydro_asetek.c file.

I have tested this with a H150i Pro and it produces output like:

temperature:0:33.70
fan:0:0:604:0
fan:1:0:618:0
fan:2:0:600:0
pump:2:2820:0

This change should work with other devices that use the asetekpro pump

This commit adds support for the --machine option to the asetekpro pump
so that it produces machine readable output for the values of the
temperature, fans and pump.

The fix was to simply add calls to the msg_machine() method similar to
what already exists in the hydro_asetek.c file.

I have tested this with a H150i Pro and it produces output like:

temperature:0:33.70
fan:0:0:604:0
fan:1:0:618:0
fan:2:0:600:0
pump:2:2820:0

This change should work with other devices that use the asetekpro pump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants