Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for mercurial VCS #52

Merged
merged 3 commits into from
Sep 8, 2013

Conversation

pokoli
Copy link

@pokoli pokoli commented Aug 27, 2013

Use .hg in the end of the repo to indicate that is a mercurial repo.

- Added mercurial for test dependency.
- Added test for mercurial checkout.
- Refactored vcs.py to reuse delete code.

    Use .hg in the end of the repo to indicate that is a mercurial repo.

    - Added mercurial for test dependency.
    - Added test for mercurial checkout.
    - Refactored vcs.py to reuse delete code.
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling e672b86 on pokoli:mercurial_support into cf1fb09 on audreyr:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.21%) when pulling 47fd5e1 on pokoli:mercurial_support into cf1fb09 on audreyr:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.6%) when pulling de1cd76 on pokoli:mercurial_support into cf1fb09 on audreyr:master.

@audreyfeldroy
Copy link
Member

Cool! Will review shortly. Thanks @pokoli!

@audreyfeldroy audreyfeldroy merged commit de1cd76 into cookiecutter:master Sep 8, 2013
@audreyfeldroy
Copy link
Member

Merged into master!

Heads up that I made a big change:

  1. Users no longer have to append .hg to the end of the repo URL.
  2. And in fact, if you append .hg, Cookiecutter won't recognize it, since it's not a valid clone-able URL.

I decided this based on the fact that hg clone https://bitbucket.org/audreyr/cookiecutter-bitbucket works but hg clone https://bitbucket.org/audreyr/cookiecutter-bitbucket.hg doesn't work.

Thank you @pokoli, appreciate your work here. I will submit a pull request to cookiecutter-trytonmodule to reflect the above.

I should note that at the moment, with the changes in this branch Cookiecutter will only work with Bitbucket and not general Mercurial repos. That is my fault, and consider that problem temporary. Hopefully we'll be able to replace the vcs.identify_repo() function with the equivalent from a package that @pydanny is working on, for identifying repos for OpenComparison/DjangoPackages.

JosephGasiorekUSDS pushed a commit to JosephGasiorekUSDS/cookiecutter that referenced this pull request Jun 30, 2024
Added CODE_OF_CONDUCT.md and COMMUNITY_GUIDELINES.md to Tier 3 + 4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue/PR relates to a feature request. high-priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants