Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text is blurry #3

Closed
wtholliday opened this issue Oct 2, 2022 · 4 comments
Closed

text is blurry #3

wtholliday opened this issue Oct 2, 2022 · 4 comments

Comments

@wtholliday
Copy link
Contributor

wtholliday commented Oct 2, 2022 •
edited
Loading

The tests now write the glyph atlas to a png.

Here's a glyph in the atlas:

image

here's that glyph rendered:

image
wtholliday added a commit that referenced this issue Oct 3, 2022
@wtholliday
re #3. Improve text sharpness.
4a57a50 
Should use `textureLoad` instead of `textureSample`.
wtholliday added a commit that referenced this issue Oct 3, 2022
@wtholliday
re #3. Fix scale factor
081a266
wtholliday added a commit that referenced this issue Oct 3, 2022
@wtholliday
re #3. Sharper text.
800ccde 
Bit of a guess.
@wtholliday
Copy link
Contributor Author

It's a bit of a hack I think, but I applied the sRGB to linear conversion to the glyph atlas and got output that's pretty close:

@wtholliday
Copy link
Contributor Author

Gonna call this fixed for now, but we'll probably need to revisit later and really do it right.

@wtholliday
Copy link
Contributor Author

Possibly relevant: mooman219/fontdue#118

@wtholliday
Copy link
Contributor Author

wgpu_glyph takes a similar approach to text rendering. Perhaps something can be gleaned from that code.

Zoxc pushed a commit to Zoxc/vger-rs that referenced this issue Jan 4, 2024
@jrmoulton @Zoxc
Fix box shadow alpha (audulus#3)
dfeced7 
The alpha channel was only being used to "dim"
the shadow effect. Now that "dimming" value is
multiplied by the alpha channel as well

Use alpha for rect painting (audulus#4)
Zoxc pushed a commit to Zoxc/vger-rs that referenced this issue Jan 4, 2024
@jrmoulton @Zoxc
Fix box shadow alpha (audulus#3)
5bde161 
The alpha channel was only being used to "dim"
the shadow effect. Now that "dimming" value is
multiplied by the alpha channel as well

Use alpha for rect painting (audulus#4)
waywardmonkeys pushed a commit to waywardmonkeys/vger-rs that referenced this issue Jun 30, 2024
@jrmoulton
Fix box shadow alpha (audulus#3)
1640170 
The alpha channel was only being used to "dim"
the shadow effect. Now that "dimming" value is
multiplied by the alpha channel as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wtholliday