Introduce observe.Status #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 25, 2022
taniwha3
approved these changes
Sep 25, 2022
krisnova
force-pushed
the
status
branch
3 times, most recently
from
bbcbe1b
to
810db7c
Compare
Signed-off-by: Kris Nóva <kris@nivenly.com>
Signed-off-by: Kris Nóva <kris@nivenly.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding more form to my work with some of the basics. We are still a long way away from "production ready" however this gets messages plumbed through from the daemon to the client with mTLS.
I want to talk more about the approach in the discord. Rust is teaching me that global mutable state is a bad idea, and our client reflects this.
Basically (right now in this PR) we read environmental variables, and build an mTLS client from scratch every time we execute a request with the scripting language.
We should talk more about this, however I think we should merge this ASAP so we can move forward with some of the other feature work.