Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow update/repost of already-published items #18

Merged
merged 2 commits into from
Nov 22, 2018

Conversation

wilddeej
Copy link
Contributor

If an item's information includes the date upon which it was published, this information
is used as part of the "published" database entry, along with the relevant link. This
allows an item with the same link to be published again later, as long as its published
date is different. For those items containing no publication date, the former behavior
is unchanged (using the link information only).
Only the RSS feed implementation for this feature is in place at this point, but it would
be trivial to implement this functionality for Atom feeds as well, by setting the
FeedSporaEntry's published_date attribute with the relevant Atom field content.

If an item's information includes the date upon which it was published, this information
is used as part of the "published" database entry, along with the relevant link.  This
allows an item with the same link to be published again later, as long as its published
date is different.  For those items containing no publication date, the former behavior
is unchanged (using the link information only).
Only the RSS feed implementation for this feature is in place at this point, but it would
be trivial to implement this functionality for Atom feeds as well, by setting the
FeedSporaEntry's published_date attribute with the relevant Atom field content.
@aurelg
Copy link
Owner

aurelg commented Nov 20, 2018

Nice feature, thanks. Users won't expect different behavior between the Atom and RSS feeds. I think it's extremely important to keep them on par feature-wise. Since it's trivial, it's certainly worth implementing it in this PR.

@wilddeej
Copy link
Contributor Author

wilddeej commented Nov 20, 2018 via email

@wilddeej
Copy link
Contributor Author

wilddeej commented Nov 20, 2018 via email

@wilddeej
Copy link
Contributor Author

wilddeej commented Nov 22, 2018 via email

@aurelg aurelg merged commit 56afd0b into aurelg:dev Nov 22, 2018
@wilddeej wilddeej deleted the enhancement/allow-updated-post_dev branch November 26, 2018 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants