-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow update/repost of already-published items #18
Merged
aurelg
merged 2 commits into
aurelg:dev
from
wilddeej:enhancement/allow-updated-post_dev
Nov 22, 2018
Merged
Allow update/repost of already-published items #18
aurelg
merged 2 commits into
aurelg:dev
from
wilddeej:enhancement/allow-updated-post_dev
Nov 22, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an item's information includes the date upon which it was published, this information is used as part of the "published" database entry, along with the relevant link. This allows an item with the same link to be published again later, as long as its published date is different. For those items containing no publication date, the former behavior is unchanged (using the link information only). Only the RSS feed implementation for this feature is in place at this point, but it would be trivial to implement this functionality for Atom feeds as well, by setting the FeedSporaEntry's published_date attribute with the relevant Atom field content.
Nice feature, thanks. Users won't expect different behavior between the Atom and RSS feeds. I think it's extremely important to keep them on par feature-wise. Since it's trivial, it's certainly worth implementing it in this PR. |
I included some commented-out code for just that purpose, but I didn't want
to fully put it in without some decent testing. Can you suggest a good
Atom feed that I could access for this purpose?
…On Tue, Nov 20, 2018 at 1:00 PM Aurélien Grosdidier < ***@***.***> wrote:
Nice feature, thanks. Users won't expect different behavior between the
Atom and RSS feeds. I think it's extremely important to keep them on par
feature-wise. Since it's trivial, it's certainly worth implementing it in
this PR.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#18 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AXIWhjDB3zjA_aolSxLzC0LYH4Bvs93Oks5uxF95gaJpZM4YrV7n>
.
|
I poked around and was able to find an Atom feed at
http://www.javarticles.com/feed/atom. It revealed a bug in the Tweepy
implementation that I will fix in the next PR. I've pushed another change
to PR #18 to include the Atom feed implementation of this new enhancement,
as requested.
…On Tue, Nov 20, 2018 at 3:06 PM Jim Howard ***@***.***> wrote:
I included some commented-out code for just that purpose, but I didn't
want to fully put it in without some decent testing. Can you suggest a
good Atom feed that I could access for this purpose?
On Tue, Nov 20, 2018 at 1:00 PM Aurélien Grosdidier <
***@***.***> wrote:
> Nice feature, thanks. Users won't expect different behavior between the
> Atom and RSS feeds. I think it's extremely important to keep them on par
> feature-wise. Since it's trivial, it's certainly worth implementing it in
> this PR.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#18 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AXIWhjDB3zjA_aolSxLzC0LYH4Bvs93Oks5uxF95gaJpZM4YrV7n>
> .
>
|
I think this one is complete and ready to be merged, unless you have
something else that needs to be done with it.
…On Tue, Nov 20, 2018 at 3:59 PM Jim Howard ***@***.***> wrote:
I poked around and was able to find an Atom feed at
http://www.javarticles.com/feed/atom. It revealed a bug in the Tweepy
implementation that I will fix in the next PR. I've pushed another change
to PR #18 to include the Atom feed implementation of this new enhancement,
as requested.
On Tue, Nov 20, 2018 at 3:06 PM Jim Howard ***@***.***> wrote:
> I included some commented-out code for just that purpose, but I didn't
> want to fully put it in without some decent testing. Can you suggest a
> good Atom feed that I could access for this purpose?
>
> On Tue, Nov 20, 2018 at 1:00 PM Aurélien Grosdidier <
> ***@***.***> wrote:
>
>> Nice feature, thanks. Users won't expect different behavior between the
>> Atom and RSS feeds. I think it's extremely important to keep them on par
>> feature-wise. Since it's trivial, it's certainly worth implementing it in
>> this PR.
>>
>> —
>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub
>> <#18 (comment)>,
>> or mute the thread
>> <https://github.com/notifications/unsubscribe-auth/AXIWhjDB3zjA_aolSxLzC0LYH4Bvs93Oks5uxF95gaJpZM4YrV7n>
>> .
>>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an item's information includes the date upon which it was published, this information
is used as part of the "published" database entry, along with the relevant link. This
allows an item with the same link to be published again later, as long as its published
date is different. For those items containing no publication date, the former behavior
is unchanged (using the link information only).
Only the RSS feed implementation for this feature is in place at this point, but it would
be trivial to implement this functionality for Atom feeds as well, by setting the
FeedSporaEntry's published_date attribute with the relevant Atom field content.