Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stagger): delay calculation #60

Merged
merged 1 commit into from
Apr 5, 2017
Merged

Conversation

dev-zb
Copy link
Contributor

@dev-zb dev-zb commented Apr 4, 2017

Stagger delay calculation for new elements included existing elements.

fixes #55

Stagger delay calculation for new elements included existing elements

fixes aurelia#55
@zewa666
Copy link
Member

zewa666 commented Apr 4, 2017

This sounds great, I'll take a proper look tomorrow. Thx for the contribution

@zewa666 zewa666 merged commit 6112d34 into aurelia:master Apr 5, 2017
@zewa666
Copy link
Member

zewa666 commented Apr 5, 2017

@z-brooks ok so I've zoomed through it and fixed some linting issues. Great work, like the refactoring you did for enter/leave to reduce code duplication 👍

@ngocvantran
Copy link

I'm sorry if this looks silly but I don't see au-stagger-leave being used anymore, is this intended? Unfortunately, I could not find any documentation to verify how I should use it, and I'm unable to use enter only staggering. Tests are passing, but they do not verify if there is a delay between items or not.

@zewa666
Copy link
Member

zewa666 commented Sep 26, 2017

@7pass thanks to the help of @z-brooks this got fixed and merged. Release inbound :) Thanks for reporting and fixing guys

@ngocvantran
Copy link

I look forward to the release. Thanks all for the great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite scrolling animation delays accumulate
3 participants