Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router-lite): non-string support for fallback #1730

Merged
merged 4 commits into from
Apr 5, 2023

Conversation

Sayan751
Copy link
Member

@Sayan751 Sayan751 commented Apr 5, 2023

Pull Request

📖 Description

🎫 Issues

👩‍💻 Reviewer Notes

📑 Test Plan

⏭ Next Steps

@Sayan751 Sayan751 requested a review from bigopon April 5, 2023 19:00
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #1730 (b566167) into master (48e3f40) will increase coverage by 0.02%.
The diff coverage is 97.87%.

@@            Coverage Diff             @@
##           master    #1730      +/-   ##
==========================================
+ Coverage   88.01%   88.04%   +0.02%     
==========================================
  Files         243      243              
  Lines       22272    22291      +19     
  Branches     5039     5047       +8     
==========================================
+ Hits        19603    19626      +23     
+ Misses       2669     2665       -4     
Impacted Files Coverage Δ
packages/router-lite/src/component-agent.ts 98.41% <ø> (ø)
packages/router-lite/src/options.ts 82.97% <ø> (ø)
packages/router-lite/src/viewport-agent.ts 84.25% <ø> (ø)
...time-html/src/observation/select-value-observer.ts 96.94% <ø> (ø)
packages/router-lite/src/validation.ts 74.49% <80.00%> (+1.94%) ⬆️
packages/router-lite/src/resources/viewport.ts 87.23% <100.00%> (ø)
packages/router-lite/src/route-context.ts 90.98% <100.00%> (ø)
packages/router-lite/src/route-tree.ts 88.46% <100.00%> (+0.08%) ⬆️
packages/router-lite/src/route.ts 98.70% <100.00%> (ø)
...ges/runtime-html/src/compiler/template-compiler.ts 98.01% <100.00%> (+0.05%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Sayan751 Sayan751 merged commit 59da952 into master Apr 5, 2023
@Sayan751 Sayan751 deleted the topic/router-lite/fallback-class branch April 5, 2023 19:51
@Sayan751
Copy link
Member Author

Sayan751 commented Apr 5, 2023

cc: @brandonseydel

AureliaEffect pushed a commit that referenced this pull request Apr 13, 2023
2.0.0-beta.4 (2023-04-13)

**Features:**

* **debounce-throttle:** flush via signals (#1739) ([af238a9](af238a9))
* **slotted:** add slotted decorator, slotchange bindable for au-slot (#1735) ([8cf87af](8cf87af))
* **router-lite:** extended support for ../ prefix, activeClass router configuration (#1733) ([bd18fde](bd18fde))
* **router-lite:** non-string support for fallback (#1730) ([59da952](59da952))
* **vite-plugin:** add vite plugin (#1726) ([564e533](564e533))
* **router-lite:** ce aliases as configured route (#1723) ([2b7f9fc](2b7f9fc))
* **router-lite:** transitionplan as nav opt ([7905d98](7905d98))

**Bug Fixes:**

* **repeat:** fix mismatchedLengthError on assigning an array with duplicate primitive values (#1737) ([cf60ac8](cf60ac8))
* **vite-plugin:** optionally resolve alias, add preliminary doc (#1731) ([3f37f8d](3f37f8d))
* **select:** insensitive multiple.bind order (#1727) ([c8d912f](c8d912f))
* **ci:** fix vite build in ci, upgrade chromedriver ([564e533](564e533))
* **proxy-observation:** prevent proxies from being wrapped in proxies again (#1716) ([7792e9c](7792e9c))

**Refactorings:**

* **children:** remove children observers from custom element def, make children deco as a hook (#1732) ([5bde983](5bde983))
* **all:** ignore dev message coverage ([5bde983](5bde983))
* **router-lite:** routable fallback ([59da952](59da952))
* **platform:** remove unnecessary properties on PLATFORM (#1722) ([7cd77ad](7cd77ad))
* **router-lite:** route definition configuration ([eba6d61](eba6d61))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant