Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin): optionally resolve alias, add preliminary doc #1731

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

bigopon
Copy link
Member

@bigopon bigopon commented Apr 5, 2023

Thanks @brandonseydel for reporting.

When using aliases, the resolution needs to be optional so that non existing package won't cause an error, per node require.resolve doc https://nodejs.org/api/modules.html#requireresolverequest-options

Add preliminary doc for the vite plugin

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #1731 (8e7545e) into master (59da952) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1731   +/-   ##
=======================================
  Coverage   88.04%   88.04%           
=======================================
  Files         243      243           
  Lines       22291    22291           
  Branches     5047     5047           
=======================================
  Hits        19626    19626           
  Misses       2665     2665           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bigopon bigopon merged commit 3f37f8d into master Apr 6, 2023
@bigopon bigopon deleted the fix/vite branch April 6, 2023 00:12
AureliaEffect pushed a commit that referenced this pull request Apr 13, 2023
2.0.0-beta.4 (2023-04-13)

**Features:**

* **debounce-throttle:** flush via signals (#1739) ([af238a9](af238a9))
* **slotted:** add slotted decorator, slotchange bindable for au-slot (#1735) ([8cf87af](8cf87af))
* **router-lite:** extended support for ../ prefix, activeClass router configuration (#1733) ([bd18fde](bd18fde))
* **router-lite:** non-string support for fallback (#1730) ([59da952](59da952))
* **vite-plugin:** add vite plugin (#1726) ([564e533](564e533))
* **router-lite:** ce aliases as configured route (#1723) ([2b7f9fc](2b7f9fc))
* **router-lite:** transitionplan as nav opt ([7905d98](7905d98))

**Bug Fixes:**

* **repeat:** fix mismatchedLengthError on assigning an array with duplicate primitive values (#1737) ([cf60ac8](cf60ac8))
* **vite-plugin:** optionally resolve alias, add preliminary doc (#1731) ([3f37f8d](3f37f8d))
* **select:** insensitive multiple.bind order (#1727) ([c8d912f](c8d912f))
* **ci:** fix vite build in ci, upgrade chromedriver ([564e533](564e533))
* **proxy-observation:** prevent proxies from being wrapped in proxies again (#1716) ([7792e9c](7792e9c))

**Refactorings:**

* **children:** remove children observers from custom element def, make children deco as a hook (#1732) ([5bde983](5bde983))
* **all:** ignore dev message coverage ([5bde983](5bde983))
* **router-lite:** routable fallback ([59da952](59da952))
* **platform:** remove unnecessary properties on PLATFORM (#1722) ([7cd77ad](7cd77ad))
* **router-lite:** route definition configuration ([eba6d61](eba6d61))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant