Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(debounce-throttle): flush via signals #1739

Merged
merged 2 commits into from Apr 13, 2023

Conversation

bigopon
Copy link
Member

@bigopon bigopon commented Apr 12, 2023

Pull Request

馃摉 Description

Support a valid use case described in #1145 , where it's desirable to flush throttled/debounced update upon some condition.

  • throttle & debounce now accept a 2nd parameter with type string | string[] as signals, to listen to and flush whenever there's a dispatch. Example:
<input value.bind="value & throttle :200 :`finishTyping`" blur.trigger="signaler.dispatchSignal('finishTyping')">
<!-- or it can be a list of signals -->
<input value.bind="value & throttle :200 :[`finishTyping`, `newUpdate`]">

Resolves #1145

Thanks @avrahamcool

@bigopon
Copy link
Member Author

bigopon commented Apr 12, 2023

cc @zewa666

@bigopon bigopon merged commit af238a9 into master Apr 13, 2023
23 checks passed
@bigopon bigopon deleted the feat/debounce-throttle-flush branch April 13, 2023 00:12
AureliaEffect pushed a commit that referenced this pull request Apr 13, 2023
2.0.0-beta.4 (2023-04-13)

**Features:**

* **debounce-throttle:** flush via signals (#1739) ([af238a9](af238a9))
* **slotted:** add slotted decorator, slotchange bindable for au-slot (#1735) ([8cf87af](8cf87af))
* **router-lite:** extended support for ../ prefix, activeClass router configuration (#1733) ([bd18fde](bd18fde))
* **router-lite:** non-string support for fallback (#1730) ([59da952](59da952))
* **vite-plugin:** add vite plugin (#1726) ([564e533](564e533))
* **router-lite:** ce aliases as configured route (#1723) ([2b7f9fc](2b7f9fc))
* **router-lite:** transitionplan as nav opt ([7905d98](7905d98))

**Bug Fixes:**

* **repeat:** fix mismatchedLengthError on assigning an array with duplicate primitive values (#1737) ([cf60ac8](cf60ac8))
* **vite-plugin:** optionally resolve alias, add preliminary doc (#1731) ([3f37f8d](3f37f8d))
* **select:** insensitive multiple.bind order (#1727) ([c8d912f](c8d912f))
* **ci:** fix vite build in ci, upgrade chromedriver ([564e533](564e533))
* **proxy-observation:** prevent proxies from being wrapped in proxies again (#1716) ([7792e9c](7792e9c))

**Refactorings:**

* **children:** remove children observers from custom element def, make children deco as a hook (#1732) ([5bde983](5bde983))
* **all:** ignore dev message coverage ([5bde983](5bde983))
* **router-lite:** routable fallback ([59da952](59da952))
* **platform:** remove unnecessary properties on PLATFORM (#1722) ([7cd77ad](7cd77ad))
* **router-lite:** route definition configuration ([eba6d61](eba6d61))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add override option for debounce and throttle
1 participant