feat(slotted): add slotted decorator #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigopon
changed the title
AureliaEffect
pushed a commit
that referenced
this pull request
Apr 13, 2023
2.0.0-beta.4 (2023-04-13) **Features:** * **debounce-throttle:** flush via signals (#1739) ([af238a9](af238a9)) * **slotted:** add slotted decorator, slotchange bindable for au-slot (#1735) ([8cf87af](8cf87af)) * **router-lite:** extended support for ../ prefix, activeClass router configuration (#1733) ([bd18fde](bd18fde)) * **router-lite:** non-string support for fallback (#1730) ([59da952](59da952)) * **vite-plugin:** add vite plugin (#1726) ([564e533](564e533)) * **router-lite:** ce aliases as configured route (#1723) ([2b7f9fc](2b7f9fc)) * **router-lite:** transitionplan as nav opt ([7905d98](7905d98)) **Bug Fixes:** * **repeat:** fix mismatchedLengthError on assigning an array with duplicate primitive values (#1737) ([cf60ac8](cf60ac8)) * **vite-plugin:** optionally resolve alias, add preliminary doc (#1731) ([3f37f8d](3f37f8d)) * **select:** insensitive multiple.bind order (#1727) ([c8d912f](c8d912f)) * **ci:** fix vite build in ci, upgrade chromedriver ([564e533](564e533)) * **proxy-observation:** prevent proxies from being wrapped in proxies again (#1716) ([7792e9c](7792e9c)) **Refactorings:** * **children:** remove children observers from custom element def, make children deco as a hook (#1732) ([5bde983](5bde983)) * **all:** ignore dev message coverage ([5bde983](5bde983)) * **router-lite:** routable fallback ([59da952](59da952)) * **platform:** remove unnecessary properties on PLATFORM (#1722) ([7cd77ad](7cd77ad)) * **router-lite:** route definition configuration ([eba6d61](eba6d61))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
At the moment, there's not a way to listen to changes of the projection within an
<au-slot/>element. This leads to the inability to have similar pattern like the@childrendeco for<au-slot/>, and sometimes one needs to resolve to some complex query with@childrento achieve the same outcome.Example code:
Using
@slotteddecoratorUsing
slotchangebinding on<au-slot>:This PR:
<au-slot/>to watch, capture and notify changes of its projection.@slotteddecoratorslotchangebinding@childrendecorator@slotteddecoratorResolves #1694
👩💻 Reviewer Notes
@slotteddecorator will add aILifecycleHooksdependency to the metadata associated with a class, and upon resolving, will provide the infrastructure to hook with<au-slot/>for change observation and notifcation📑 Test Plan
@slottedquery@slottedquery@slottedworking together@Sayan751 @fkleuver @brandonseydel
Doc can be temporarily viewed here