fix(router): store root/default page instruction correctly #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user used the browser's "back" button, the root/home page was not correctly loaded. close aurelia#1812
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1869 +/- ##
==========================================
+ Coverage 88.68% 88.76% +0.08%
==========================================
Files 248 248
Lines 22334 22337 +3
Branches 5198 5200 +2
==========================================
+ Hits 19806 19827 +21
+ Misses 2528 2510 -18 ☔ View full report in Codecov by Sentry. |
jwx
approved these changes
Jan 12, 2024
AureliaEffect
pushed a commit
that referenced
this pull request
Jan 26, 2024
2.0.0-beta.10 (2024-01-26) **BREAKING CHANGE:** * **enums:** string literal types replace const enums (#1870) ([e21e0c9](e21e0c9)) **Features:** * **route-recognizer:** support for route parameter constraints (#1862) ([8f29cfd](8f29cfd)) **Bug Fixes:** * **docs:** various doc fix * **au-slot:** properly handle nested projection registration (#1881) ([00e8dee](00e8dee)) * **kernel:** stack preserving error logging for console (#1884) ([030bfa1](030bfa1)) * **portal:** remove target marker when deactivated (#1883) ([3db4c17](3db4c17)) * **validation:** evaluation of tagged rules from bindings (#1878) ([43d12f6](43d12f6)) * **validation:** property parsing with lambda and istanbul (#1877) ([71f82cf](71f82cf)) * **router:** store root/default page instruction correctly (#1869) ([84e6380](84e6380)) * **runtime-html:** template wrapping (#1875) ([bfdaa3b](bfdaa3b)) * **i18n:** handle change of key in t.bind (#1868) ([c185764](c185764)) * **router-lite:** Router injection and ignoring null/undefined values for query parameters (#1859) ([6a79bc9](6a79bc9)) * **router-lite:** injection of Router alias ([6a79bc9](6a79bc9)) * **runtime-html:** fix broken tests ([bfdaa3b](bfdaa3b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
When a user used the browser's "back" button, the root ("/") default page was not correctly reloaded.
🎫 Issues
Resolves #1812.
👩💻 Reviewer Notes
In the current code (without this PR), all routing instructions are always prepended with
-(updateNavigation).The issue is due to a simple fact:
-+-. And-(minus) is used to clear the current path/page. Thus, when we navigate to/, then to another page, the root page is lost and replaced by-.My current fix simply checks whether the instruction is empty, and if so, it prevent the clear instruction to be added.
📑 Test Plan
⏭ Next Steps