fix(kernel): stack preserving error logging for console

[Sayan751]

Pull Request

📖 Description

As of now, the console log for the following code produced incorrect/obfuscated stack information.

try {
  throw new Error('foo');
} catch (ex) {
  this.logger.error(ex);
}

It produced the following stack information:

2024-01-25T19:59:55.854Z [ERR my-el] Error: foo
emit                  @ index.mjs:1509
K                     @ index.mjs:1633
error                 @ index.mjs:1613
fn                    @ my-app.ts:22
attached              @ my-app.ts:14
Ot                    @ index.mjs:4312
$t                    @ index.mjs:4146
bind                  @ index.mjs:4071
activate              @ index.mjs:4035
$t                    @ index.mjs:4143
bind                  @ index.mjs:4071
activate              @ index.mjs:4035
(anonymous)           @ index.mjs:4744
onResolve             @ index.mjs:257
(anonymous)           @ index.mjs:4744
onResolve             @ index.mjs:257
activate              @ index.mjs:4744
(anonymous)           @ index.mjs:4858
onResolve             @ index.mjs:257
start                 @ index.mjs:4854
(anonymous)           @ main.ts:12
./src/main.ts         @ main.ts:13
__webpack_require__   @ bootstrap:24
(anonymous)           @ startup:6
(anonymous)           @ startup:6

Friendlier would be something like below (result of directly logging the error using console.error).

2024-01-25T19:59:55.854Z [ERR my-el] Error: foo
  at MyEl.fn (my-app.ts:18:1)
  at MyEl.attached (my-app.ts:14:1)
  at Controller.Ot (index.mjs:4312:1)
  at Controller.$t (index.mjs:4146:1)
  at Controller.bind (index.mjs:4071:1)
  at Controller.activate (index.mjs:4035:1)
  at Controller.$t (index.mjs:4143:1)
  at Controller.bind (index.mjs:4071:1)
  at Controller.activate (index.mjs:4035:1)
  at index.mjs:4744:1
emit                  @ index.mjs:1509
K                     @ index.mjs:1633
error                 @ index.mjs:1613
fn                    @ my-app.ts:22
attached              @ my-app.ts:14
Ot                    @ index.mjs:4312
$t                    @ index.mjs:4146
bind                  @ index.mjs:4071
activate              @ index.mjs:4035
$t                    @ index.mjs:4143
bind                  @ index.mjs:4071
activate              @ index.mjs:4035
(anonymous)           @ index.mjs:4744
onResolve             @ index.mjs:257
(anonymous)           @ index.mjs:4744
onResolve             @ index.mjs:257
activate              @ index.mjs:4744
(anonymous)           @ index.mjs:4858
onResolve             @ index.mjs:257
start                 @ index.mjs:4854
(anonymous)           @ main.ts:12
./src/main.ts         @ main.ts:13
__webpack_require__   @ bootstrap:24
(anonymous)           @ startup:6
(anonymous)           @ startup:6

Reproduction: https://stackblitz.com/edit/logging-and-stacktrace?file=src%2Fmy-app.ts,src%2Fmain.ts

This PR fixes this issue.

🎫 Issues

👩‍💻 Reviewer Notes

📑 Test Plan

⏭ Next Steps

[codecov]

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (010a4ad) 88.55% compared to head (6603da1) 88.79%.
Report is 77 commits behind head on master.

Files	Patch %	Lines
packages/runtime-html/src/templating/controller.ts	76.71%	17 Missing ⚠️
packages/runtime/src/binding/ast.visitor.ts	78.12%	7 Missing ⚠️
packages/router-lite/src/route-expression.ts	33.33%	6 Missing ⚠️
packages/runtime/src/binding/ast.eval.ts	90.00%	5 Missing ⚠️
packages/platform/src/index.ts	81.81%	4 Missing ⚠️
.../router/src/instructions/instruction-parameters.ts	81.81%	2 Missing ⚠️
packages/compat-v1/src/compat-delegate.ts	50.00%	1 Missing ⚠️
packages/i18n/src/t/translation-binding.ts	88.88%	1 Missing ⚠️
packages/route-recognizer/src/index.ts	98.07%	1 Missing ⚠️
...ges/runtime-html/src/compiler/template-compiler.ts	95.65%	1 Missing ⚠️
... and 1 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1884      +/-   ##
==========================================
+ Coverage   88.55%   88.79%   +0.23%     
==========================================
  Files         248      247       -1     
  Lines       22290    22317      +27     
  Branches     5180     5186       +6     
==========================================
+ Hits        19739    19816      +77     
+ Misses       2551     2501      -50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bigopon]

Nice work @Sayan751 . I dont think we need to change the message property name. Though if you insist we can discuss more on that

[bigopon]

👍

[bigopon]

it should still be named message I think. It can be a plain (string) or packed (Error) message

[Sayan751]

Thanks @bigopon!