fix(router-lite): Router injection and ignoring null/undefined values for query parameters #1859
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1859 +/- ##
==========================================
- Coverage 88.55% 88.55% -0.01%
==========================================
Files 248 248
Lines 22290 22292 +2
Branches 5180 5181 +1
==========================================
+ Hits 19739 19740 +1
- Misses 2551 2552 +1 ☔ View full report in Codecov by Sentry. |
|
Are the tests covering the null/undefined issue? I dont see any tests that have a similar template to the reported issue. Edit: nvm, i just read the last 2 comments so i got the changes. Im not sure we should be that concerned by the loss of data, because we seem to only have 2 choices: have wrong data or no dat, both should be considered loss to me. Absence of data should be the less bad option probably? |
I agree. If you don't see any issue with the changes, then maybe we can go forward and merge it. |
2.0.0-beta.10 (2024-01-26) **BREAKING CHANGE:** * **enums:** string literal types replace const enums (#1870) ([e21e0c9](e21e0c9)) **Features:** * **route-recognizer:** support for route parameter constraints (#1862) ([8f29cfd](8f29cfd)) **Bug Fixes:** * **docs:** various doc fix * **au-slot:** properly handle nested projection registration (#1881) ([00e8dee](00e8dee)) * **kernel:** stack preserving error logging for console (#1884) ([030bfa1](030bfa1)) * **portal:** remove target marker when deactivated (#1883) ([3db4c17](3db4c17)) * **validation:** evaluation of tagged rules from bindings (#1878) ([43d12f6](43d12f6)) * **validation:** property parsing with lambda and istanbul (#1877) ([71f82cf](71f82cf)) * **router:** store root/default page instruction correctly (#1869) ([84e6380](84e6380)) * **runtime-html:** template wrapping (#1875) ([bfdaa3b](bfdaa3b)) * **i18n:** handle change of key in t.bind (#1868) ([c185764](c185764)) * **router-lite:** Router injection and ignoring null/undefined values for query parameters (#1859) ([6a79bc9](6a79bc9)) * **router-lite:** injection of Router alias ([6a79bc9](6a79bc9)) * **runtime-html:** fix broken tests ([bfdaa3b](bfdaa3b))
Pull Request
📖 Description
🎫 Issues
Closes #1855 and #1857
👩💻 Reviewer Notes
📑 Test Plan
⏭ Next Steps