fix(au-slot): properly handle nested projection registration #1881
Conversation
|
@Sayan751 thanks for the issues, it's an nice find. Please help review the PR, if you have any use case needed to be covered, pls feel free to add them to the tests. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1881 +/- ##
==========================================
+ Coverage 88.55% 88.79% +0.24%
==========================================
Files 248 247 -1
Lines 22290 22323 +33
Branches 5180 5186 +6
==========================================
+ Hits 19739 19822 +83
+ Misses 2551 2501 -50 ☔ View full report in Codecov by Sentry. |
| @@ -426,6 +426,13 @@ export class Container implements IContainer { | |||
| disposableResolvers.clear(); | |||
| } | |||
|
|
|||
| public useResources(container: Container): void { | |||
There was a problem hiding this comment.
@bigopon Can we mark this as internal? And naturally also in the interface.
There was a problem hiding this comment.
We cannot mark this as internal, as it'll still need to be public from kernel to be used in other packages. I've marked it as semi private though. Normally apps won't even need to reach to this API.
2.0.0-beta.10 (2024-01-26) **BREAKING CHANGE:** * **enums:** string literal types replace const enums (#1870) ([e21e0c9](e21e0c9)) **Features:** * **route-recognizer:** support for route parameter constraints (#1862) ([8f29cfd](8f29cfd)) **Bug Fixes:** * **docs:** various doc fix * **au-slot:** properly handle nested projection registration (#1881) ([00e8dee](00e8dee)) * **kernel:** stack preserving error logging for console (#1884) ([030bfa1](030bfa1)) * **portal:** remove target marker when deactivated (#1883) ([3db4c17](3db4c17)) * **validation:** evaluation of tagged rules from bindings (#1878) ([43d12f6](43d12f6)) * **validation:** property parsing with lambda and istanbul (#1877) ([71f82cf](71f82cf)) * **router:** store root/default page instruction correctly (#1869) ([84e6380](84e6380)) * **runtime-html:** template wrapping (#1875) ([bfdaa3b](bfdaa3b)) * **i18n:** handle change of key in t.bind (#1868) ([c185764](c185764)) * **router-lite:** Router injection and ignoring null/undefined values for query parameters (#1859) ([6a79bc9](6a79bc9)) * **router-lite:** injection of Router alias ([6a79bc9](6a79bc9)) * **runtime-html:** fix broken tests ([bfdaa3b](bfdaa3b))
📖 Description
Currently in nested projection, the container hierarchy does not have all information related to projector and projection context making it unable to resolve the right instances of projectors. This PR fix this.
📑 Test Plan
Added a test based on reported case from related PR with slightly more complicated usage.