Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(all): support non-modal dialogs #350

Conversation

StrahilKazlachev
Copy link
Contributor

I'm proposing to support non-modal dialogs - the native dialogs support it.

  1. A modal dialog is always on top(visually)
    • Renderers will have to append any non-modal dialog before existing modal ones in the host
    • the DialogService .controllers property will still keep the controllers in the order they were open
  2. Introduce a focused concept - the dialog the user is currently interacting with(accepting naming propositions)
    • apply actions on the focused dialog
      • whether or not and on which dialog, to apply the keyboard actions when there are only non-modal dialogs
    • the top modal dialog is always the focused
    • when there are no modal dialogs open there may or may not be a focused dialog

Did just minor changes to start a discussion.
@EisenbergEffect @PWKad what do you think?

@bigopon
Copy link
Member

bigopon commented Jun 2, 2018

Would be nice if we could expose the focus state on dialog controller, so that non blocking dialogs can leverage it to set proper z index

@davismj
Copy link
Member

davismj commented Jun 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants