-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove tslint #26
Comments
We should probably base this on https://github.com/aurelia/aurelia/blob/master/.eslintrc.js (we just removed tslint on the vs-code extension and did this), as it's the one being used for Au2. The best would be to publish an official eslint-config in the aurelia org which we can depend upon. |
sure, it's up to you guys, I think that's a lot more complicated and opinionated though, I'm not sure hundreds of lines of config is a good idea for a new project. |
I thought we were talking about this repo :) If it's the generated one, I totally agree, we should stick to adding the recommended one and leave it up to the user to add more specific rules. |
yeah, sorry, I meant the one that |
Will do, this repo was created before aurelia monorepo switched from tslint to eslint. BTW, is anyone else experiencing performance issue with eslint + typescript-eslint? It's very very slow in my sublime (I didn't try vscode). |
I don't think so... at the very least performance is tolerable in vscode, how does it perform if you run it by hand? To be fair, I have no idea how |
There is definitely something wrong with typescript-eslint in sublime. vscode is as fast as it could be. vscode-eslint is definitely running as a daemon (vscode-languageclient). While sublime's eslint runs simple command each time. I need to switch back to eslint_d (daemon) in sublime. I used eslint_d few years back, than switched to normal eslint due to acceptable performance and less config. |
tslint is deprecated (and I think no longer maintained), in favor of using eslint. The config should just be this
.eslintrc.json
recommended settings come from https://github.com/typescript-eslint/typescript-eslint/blob/master/docs/getting-started/linting/README.md
The text was updated successfully, but these errors were encountered: