Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove tslint #26

Closed
xenoterracide opened this issue Apr 19, 2020 · 7 comments · Fixed by #27
Closed

remove tslint #26

xenoterracide opened this issue Apr 19, 2020 · 7 comments · Fixed by #27
Assignees

Comments

@xenoterracide
Copy link

xenoterracide commented Apr 19, 2020

tslint is deprecated (and I think no longer maintained), in favor of using eslint. The config should just be this

.eslintrc.json

{
  "parser": "@typescript-eslint/parser", // Specifies the ESLint parser
  "plugins": ["@typescript-eslint"],
  "extends": [
    "eslint:recommended",
    "plugin:@typescript-eslint/eslint-recommended",
    "plugin:@typescript-eslint/recommended"
  ],
  "rules": {
    // Place to specify ESLint rules. Can be used to overwrite rules specified from the extended configs
    // e.g. "@typescript-eslint/explicit-function-return-type": "off",
  }
}

recommended settings come from https://github.com/typescript-eslint/typescript-eslint/blob/master/docs/getting-started/linting/README.md

@pkkummermo
Copy link

We should probably base this on https://github.com/aurelia/aurelia/blob/master/.eslintrc.js (we just removed tslint on the vs-code extension and did this), as it's the one being used for Au2. The best would be to publish an official eslint-config in the aurelia org which we can depend upon.

@xenoterracide
Copy link
Author

xenoterracide commented Apr 19, 2020

sure, it's up to you guys, I think that's a lot more complicated and opinionated though, I'm not sure hundreds of lines of config is a good idea for a new project.

@pkkummermo
Copy link

I thought we were talking about this repo :) If it's the generated one, I totally agree, we should stick to adding the recommended one and leave it up to the user to add more specific rules.

@xenoterracide
Copy link
Author

xenoterracide commented Apr 19, 2020

yeah, sorry, I meant the one that npx makes aurelia -s typescript generates.

@3cp
Copy link
Member

3cp commented Apr 19, 2020

Will do, this repo was created before aurelia monorepo switched from tslint to eslint.

BTW, is anyone else experiencing performance issue with eslint + typescript-eslint? It's very very slow in my sublime (I didn't try vscode).

@3cp 3cp self-assigned this Apr 19, 2020
@xenoterracide
Copy link
Author

xenoterracide commented Apr 19, 2020

I don't think so... at the very least performance is tolerable in vscode, how does it perform if you run it by hand? To be fair, I have no idea how eslint performs otherwise.

@3cp
Copy link
Member

3cp commented Apr 19, 2020

There is definitely something wrong with typescript-eslint in sublime. vscode is as fast as it could be.

vscode-eslint is definitely running as a daemon (vscode-languageclient). While sublime's eslint runs simple command each time. I need to switch back to eslint_d (daemon) in sublime. I used eslint_d few years back, than switched to normal eslint due to acceptable performance and less config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants