canDeactivate() is triggered twice

[vizo]

canDeactivate() is triggered twice when you navigate to another route where canActivate returns new Redirect('...').

Is there any workaround?

[EisenbergEffect]

Hmmm. That is an interesting problem. I'll need to think a bit about it.

[flieks]

I also have the canDeactivate function exectued twice but i don't have a canActivate in the next route. When this problem happens, the deactivate function doesn't get triggered aldough the page is navigated away from.

note: ok seems the detached() was called instead. Which is a bit strange, because it's not an attribute or custom element. It's a base class which is overriden. In some/most situations it calls deactivate. In some it calls detached. I don't know why but cleanup works now.

[davismj]

What is the desired behavior here? If AuthorizeStep throws a Redirect, does the AuthorizeStep need to be run again? if so, then a "pick up where you left off" strategy makes sense. If not, then perhaps we just want to prevent multiple calls to the same canDeactivate() per activation cycle?

[jeffgrann]

I believe that I just ran into this as well. canDeactivate is triggered, then there is a redirect, and then canDeactivate is triggered again. Like @flieks, there is no canActivate for me either, so it has nothing to do with that. This has been a bug for over 2 years. I think the suggestion by @davismj is the way to go: prevent multiple calls to the same canDeactivate() per activation cycle.

[c350156378]

the same issue

[EisenbergEffect]

Are we back-porting all of this to the TS conversion, so that we don't have a regression?

[davismj]

Gunna update the TS conversion PR with changes here.