Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(activation.js) fix failing tests #194

Closed
wants to merge 2 commits into from

Conversation

alvarezmario
Copy link
Contributor

This fix a typo in the activation.js file when is used if instead of for.

@bryanrsmith
Copy link
Contributor

Can you explain the problem this solves? The previous version looks correct to me.

@alvarezmario
Copy link
Contributor Author

Tests... run the tests on the master and you'll see

@alvarezmario
Copy link
Contributor Author

Well... I check it carefully and it turns out that it was failing because the controllers were undefined, I update my PR. Please check it out.

@alvarezmario alvarezmario changed the title URGENT - fix(activation.js) used if when should be for fix(activation.js) fix failing tests Aug 26, 2015
@bryanrsmith
Copy link
Contributor

@EisenbergEffect Could you review this one? I'm not up to speed on the templating changes. Is this just happening because the tests are running against the current release of templating instead of master?

@EisenbergEffect
Copy link
Contributor

I'll take care of this one.

@EisenbergEffect
Copy link
Contributor

This doesn't seem right to me. If there's a bug on master it probably relates to the changes that were made to the templating engine's internal structures that I'm trying to lock down. I think an update of the deps and a test run would probably see them pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants