-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: more permissive deletes #333
Conversation
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #333 +/- ##
=======================================
Coverage 71.98% 71.98%
=======================================
Files 45 45
Lines 2920 2920
=======================================
Hits 2102 2102
Misses 818 818 ☔ View full report in Codecov by Sentry. |
PR Type
Bug fix, Enhancement
Description
delete
method insemantic_router/layer.py
to handle non-existent routes more permissively by logging a warning instead of raising aValueError
and ensuring the index is updated.pyproject.toml
from0.0.47
to0.0.48
.Changes walkthrough 📝
layer.py
Modify route deletion logic to be more permissive
semantic_router/layer.py
delete
method.ValueError
with a warning log and an index delete operation.pyproject.toml
Bump version to 0.0.48
pyproject.toml
0.0.47
to0.0.48
.