feat: formatting, fixes and improvements

[paulbuechner]

Hi Mike,

appreciate your work in providing some maintenance love to the project.

This PR includes the following features, fixes, and improvements:

• Formatting by: https://github.com/sumneko/lua-language-server/wiki/Formatter
• Updated BlizzardActionBars to include all available ActionBars:
  • Icon not working on some bars Sellorio/mega-macro#177
• Temporarily disable MainMenuBar/MainActionBar tooltip to prevent: [ADDON_ACTION_BLOCKED] AddOn 'MegaMacro' tried to call the protected function ''
  • ActionButton locked: [ADDON_ACTION_BLOCKED] AddOn 'MegaMacro' tried to call the protected function Sellorio/mega-macro#200
• Temporarily disable range-based hotkey coloring to prevent:
  • macro hotkeys flicked on main bar only Sellorio/mega-macro#176
• UI fixes and improvements
• Refactor EventFrame to support fixed update intervals
• Add linting support for new known and unknown conditionals:
  • New 'known:' and 'noknown:' conditionals Sellorio/mega-macro#199
• Add UTF-8 support when parsing characters
• Fix channeling/nochanneling modifiers
• Updated TOC
• Updated README

Cheers 😊

fixes Sellorio#177, Sellorio#199

[paulbuechner]

Do not merge yet... more fixes are coming. Preferably convert it to draft.

Also, I'd love some feedback on this PR, so we can discuss the changes I made. 😊

[aurelion314]

FYI something is causing some stutter with this branch. I also got some errors during solo shuffle but was too into it to remember what it was heh. I'll keep playing with it but if you have any idea what is causing the CPU usage let me know.

For reference, here is AddonUsage for both version. This branch is using more than twice the CPU, and almost 20mb more memory:

Current version:

[paulbuechner]

Thanks for the feedback. I'll definitely have a look soon 👀

[aurelion314]

It seems to be related to UTF-8, even though the error I saw actually said it came from WeakAura, but it doesn't do that when I revert to the old version, so I think the UTF-8 change here is being shared and not playing nice with other addons.

[JoeLatte88]

has anyone had time to dive deeper into the potential UTF-8 issue? I may take a peek to see if I can help, but my exp with these things are very limited.

[aurelion314]

Maybe we can turn this into smaller PRs? @paulbuechner or @JoeLatte88. It is difficult to dig into what actually changed since so many files have formatting updates. Combine that with multiple feature changes and it becomes difficult to isolate what is causing the bug and/or the increased CPU load.

Unfortunately I've been busy and not playing WoW much so I am unlikely to dig through this myself in the near future :\

[JoeLatte88]

I agree on the "smaller PRs"

[JoeLatte88]

@paulbuechner , perhaps we should roll back the UTF-8 changes and deliver the problem fixes for the time being. I'll go ahead and cherry pick UTF-8 changes out in a clone of your branch and verify if performance is back to what we'd expect. At least then, we can push this out to fix issues and then work on optimization for UTF-8

[paulbuechner]

Hey! I'm on it today... let me check some changes I made to confirm if the issue is really related to UTF-8.

[paulbuechner]

@aurelion314 @JoeLatte88

Some information I've found:

The massive memory consumption is caused when loading the icons here to make them searchable in the icon browser when creating a macro.

If we disable the feature the icon starts idling around 700k

Nevertheless, a memory leak/creep is slowly ticking up...

EDIT: Reading some resources on this topic I think we should be fine with this issue:

Regarding the massive memory consumption... I propose rewriting the icon browser to only load when creating a macro. Maybe something like WeakAura has, which works like:

1. Do not load & show any icons in the icon browser until the user enters the spell name. This will prevent us from loading all icons simultaneously -> only load and cache what is requested.
2. Implement something like use-debounce to make loading the requested icons, even more, memory/CPU efficient.
3. Invalidate cache if icon browser is closed / macro is created to free up memory.

[JoeLatte88]

@paulbuechner , is the current code is a safe state from a performance perspective for us to review for approval? this is already a pretty big PR hehehe :)

would make sense to push and release what we have and we can work on further optimizations and such in a separate PR to at least get the fixes out

[paulbuechner]

The current state works well for me. At the moment I've no further changes planned. I gave you the info I figured out about @aurelion314 concerns here if you would like to do further investigations.

Also I've documented any noticeable changes at the top.

[JoeLatte88]

@aurelion314 , I reviewed the code and a VAST majority of the files changed are just adding spaces or updating tabbed spacing across some files. I don't see an issue with some of the updates from a code perspective which aren't already mentioned in @paulbuechner notes which will go as part of the addon release notes.

[aurelion314]

Nice! Unfortunately I stopped playing and don't even have WoW installed to try this out >_>

@paulbuechner do you want to make this PR directly into the original (https://github.com/Sellorio/mega-macro)? Sellorio has to finalize the merge anyway, and I don't want to hold up your updates.

[paulbuechner]

Ok. I opened the PR (Sellorio#202).

Let's see how it goes 😃