Fully flesh out schema_set specification #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twojtasz
approved these changes
Oct 10, 2018
|
Yep will do the rebase. |
The spec did not match the documentation, it only had primitives and none of the other object lists.
jlisee
force-pushed
the
jlisee/full-stream-set-schema
branch
from
d5573ed
to
4ba87fb
Compare
jlisee
added a commit
that referenced
this pull request
Oct 11, 2018
The spec did not match the documentation, it only had primitives and none of the other object lists. It now contains the full list with an example to match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec did not match the documentation, it only had primitives and
none of the other object lists.