Specification for reconfigure message #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a client to adjust how a server transform the data it sends in XVIZ format. In order to make this happen I had to add support for the google.protobuf.Struct well known type to protobuf.js. The upside it lets us basically embed JSON directly into protobuf for use cases like configuration updates. It also does it in a way that is faster or more dense than raw text.
twojtasz
approved these changes
Nov 26, 2018
twojtasz
pushed a commit
that referenced
this pull request
Jan 22, 2019
This allows a client to adjust how a server transform the data it sends in XVIZ format. In order to make this happen I had to add support for the google.protobuf.Struct well known type to protobuf.js. The upside it lets us basically embed JSON directly into protobuf for use cases like configuration updates. It also does it in a way that is faster or more dense than raw text.
twojtasz
pushed a commit
that referenced
this pull request
Jan 22, 2019
This allows a client to adjust how a server transform the data it sends in XVIZ format. In order to make this happen I had to add support for the google.protobuf.Struct well known type to protobuf.js. The upside it lets us basically embed JSON directly into protobuf for use cases like configuration updates. It also does it in a way that is faster or more dense than raw text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a client to adjust how a server transform the data it
sends in XVIZ format.
In order to make this happen I had to add support for the
google.protobuf.Struct well known type to protobuf.js. The upside it
lets us basically embed JSON directly into protobuf for use cases like
configuration updates. It also does it in a way that is faster or
more dense than raw text.