Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prophyc Babel #20

Merged
merged 15 commits into from
Mar 13, 2019
Merged

Prophyc Babel #20

merged 15 commits into from
Mar 13, 2019

Conversation

kamichal
Copy link
Collaborator

  • prophyc.generators.schema: introduced schema generator
  • prophyc.model:
    • shaped nodes inheritance tree,
    • handling docstrings,
    • split str() and repr() functionality on model tree objects,
    • unicode support in node name and node docstring
  • prophyc.parsers.isar collects docstrings

@coveralls
Copy link

coveralls commented Jan 12, 2019

Coverage Status

Coverage increased (+0.3%) to 99.599% when pulling 1d1d2a1 on babel into 094e29b on master.

@kamichal
Copy link
Collaborator Author

OMG. Coverage decreased -0.002%

@kamichal kamichal changed the title [WIP] Prophyc Babel, part 1 [WIP] Prophyc Babel Feb 11, 2019
@kamichal
Copy link
Collaborator Author

Reformed changelog entry:

1.2.0

  • prophyc.generators.schema: introduced schema generator
  • prophyc.parsers.isar collects docstrings
  • prophyc.model:
    • quite large refactor performed, shaped nodes inheritance tree
    • each node gets reproducible repr() (added renew package as dependency)
    • each node gets str implementation that returns a valid prophy schema language
    • each node may have a docstring
    • node name and docstring can be defined in unicode (python2)
    • Constant can be defined with numbers in hexadecimal format

@kamichal kamichal changed the title [WIP] Prophyc Babel Prophyc Babel Feb 12, 2019
@aurzenligl aurzenligl self-requested a review February 17, 2019 21:11
Copy link
Owner

@aurzenligl aurzenligl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done :) I like the idea of using repr to make an evaluable pure-Python representation of model - it's simple and works.

I have a couple of comments, most important issue for me is naming of things related to prophy language with word prophy instead of schema -> explanation in comments.

prophyc/options.py Outdated Show resolved Hide resolved
prophyc/generators/schema.py Outdated Show resolved Hide resolved
prophyc/generators/schema.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
prophyc/model.py Outdated Show resolved Hide resolved
prophy/generators.py Outdated Show resolved Hide resolved
@kamichal
Copy link
Collaborator Author

OK, that's it. I promise I'll not change anything on this branch anymore. Please review the last commits. In my opinion it's ready to be merged after accepting the requirement constrain for renew.

Copy link
Owner

@aurzenligl aurzenligl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks jolly good to me :) would you like to have it released as 1.2.0?

@kamichal
Copy link
Collaborator Author

kamichal commented Mar 13, 2019

Yes, seems 1.2.0 is the nicer option.
But before that please review #24.
Let's add any other changes (if any) in separate pull request.
51 files changed, 3k+ additions and 1k5+ deletions went far beyond human brain's limits.

@kamichal kamichal deleted the babel branch March 20, 2019 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants