-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prophyc Babel #20
Prophyc Babel #20
Conversation
kamichal
commented
Jan 12, 2019
- prophyc.generators.schema: introduced schema generator
- prophyc.model:
- shaped nodes inheritance tree,
- handling docstrings,
- split str() and repr() functionality on model tree objects,
- unicode support in node name and node docstring
- prophyc.parsers.isar collects docstrings
OMG. Coverage decreased -0.002% |
Adding lightweight doc creator as a tox env.
Tightening Struct and Union creation arguments
Reformed changelog entry: 1.2.0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done :) I like the idea of using repr to make an evaluable pure-Python representation of model - it's simple and works.
I have a couple of comments, most important issue for me is naming of things related to prophy language with word prophy
instead of schema
-> explanation in comments.
OK, that's it. I promise I'll not change anything on this branch anymore. Please review the last commits. In my opinion it's ready to be merged after accepting the requirement constrain for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks jolly good to me :) would you like to have it released as 1.2.0?
Yes, seems |