Allow negative values for enum in ISAR #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 15, 2016 17:06
aurzenligl
requested changes
Dec 16, 2016
| if len(elem): | ||
| return model.Enum(elem.get("name"), [make_enum_member(member) for member in elem]) | ||
| values = set() |
There was a problem hiding this comment.
Consider refactoring duplicate-checking logic to separate function.
It could be private module-scope function (_check...) or function defined inside make_enum function.
| value = "0x{:X}".format(0x100000000 + int_value) | ||
| except ValueError as e: | ||
| if warn: | ||
| warn(str(e)) |
There was a problem hiding this comment.
I'm not sure if it's allowed to use identifiers as enum values in isar, but its safer if we assume its possible.
Let's assume enum like this is correct:
<x>
<enum name="EEnum">
<enum-member name="EEnum_A" value="SOME_VALUE"/>
</enum>
</x>
And remove this warning:
prophyc: warning: invalid literal for int() with base 0: 'SOME_VALUE'
You can add/change a testcase to ensure that such enum value compiles correctly.
…entifier as value
|
See if it is OK now. |
|
Merged, thank you. When would you like it released? I can do it immediately or wait until the end of week (and release it with yet another change then). |
|
It can wait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature will work as it already is implemented for Sack: negative values are stored as positive.
Exception will be thrown if as a result the same value will be used twice.