add m_can peripheral #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbosb
requested changes
Aug 1, 2024
There was a problem hiding this comment.
At the moment, the style workflow is failing. There is a <avp64>/utils/format script you can run to check if your files are formatted accordingly to the clang-format file.
Run
<avp64>/utils/format -nto check if the files are formatted correctly<avp64>/utils/format -ito automatically format the files
Once you're done with those small changes, just amend the commit and force push it to your branch. The pull request will update automatically.
src/avp64/system.cpp
Outdated
| @@ -108,13 +121,17 @@ system::system(const sc_core::sc_module_name& nm): | |||
| addr_hwrng("addr_hwrng", { HWRNG_LO, HWRNG_HI }), | |||
| addr_spi("addr_spi", { SPI_LO, SPI_HI }), | |||
| addr_gpio("addr_gpio", { GPIO_LO, GPIO_HI }), | |||
| addr_can("addr_can", { CAN_LO, CAN_HI }), | |||
| addr_can_messageram("addr_can_messageram", { CAN_MESSAGERAM_LO, CAN_MESSAGERAM_HI }), | |||
There was a problem hiding this comment.
This line is to long (the clang-format file allows 79 characters per column). To keep it in one line, i suggest to rename CAN_MESSAGERAM_* to CAN_MSGRAM_*.
There was a problem hiding this comment.
I just noticed that addr_can_messageram needs to be shortened to addr_can_msgram, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.