Added OIDC MFA EndPoint #189
Conversation
|
Need to add a few more tests |
Public API Addition - login(withOTP otp: String, mfaToken: String) Added MFA Errors Public API New Error - isMultifactorTokenInvalid Added Error Tests Added Endpoint Tests
| @@ -67,6 +68,17 @@ struct Auth0Authentication: Authentication { | |||
| return Request(session: session, url: resourceOwner, method: "POST", handle: authenticationObject, payload: payload, logger: self.logger, telemetry: self.telemetry) | |||
| } | |||
|
|
|||
| func login(withOTP otp: String, mfaToken: String) -> Request<Credentials, AuthenticationError> { | |||
There was a problem hiding this comment.
android has the parameters in the opposite order. Would you be open to swap them?
There was a problem hiding this comment.
TBH this was commented in your Android PR, if you say loginWithOTP you would expect that the otp would be the first parameter. auth0/Auth0.Android#146 (comment)
Auth0/Authentication.swift
Outdated
|
|
||
| ``` | ||
| Auth0. | ||
| .authentication(clientId: clientId, domain: "samples.auth0.com") |
Auth0/Authentication.swift
Outdated
| } | ||
| ``` | ||
|
|
||
| - parameter otp: One time password supplied by MFA Authenticator |
There was a problem hiding this comment.
the method below adds indentation after the :. Should this do the same?
| @@ -275,6 +320,7 @@ class AuthenticationErrorSpecSharedExamplesConfiguration: QuickConfiguration { | |||
| it("should not match any known error") { | |||
| expect(error.isMultifactorCodeInvalid).to(beFalse(), description: "should not match mfa invalid") | |||
| expect(error.isMultifactorEnrollRequired).to(beFalse(), description: "should not match mfa enroll") | |||
| expect(error.isMultifactorCodeInvalid).to(beFalse(), description: "should not match code invalid") | |||
There was a problem hiding this comment.
what about isMultifactorTokenInvalid?
| } | ||
| } | ||
|
|
||
| it("should fail login with bad otp") { |
There was a problem hiding this comment.
this one is a dupe of the above (i can't spot any diff)
There was a problem hiding this comment.
Have replaced with invalid mfa token test
| @@ -13,7 +13,7 @@ | |||
| // all copies or substantial portions of the Software. | |||
| // | |||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | |||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | |||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,u | |||
There was a problem hiding this comment.
is my keyboard, it has issues :(
| expect(error.isMultifactorTokenInvalid) == true | ||
| } | ||
|
|
||
| it("should detect invalid malformed mfa token") { |
There was a problem hiding this comment.
should detect invalid malformed mfa token -> should detect malformed mfa token
Public API
Methods Added:
login(withOTP otp: String, mfaToken: String)Errors Added
isMultifactorTokenInvalidTests
Added Error Tests
Added Endpoint Tests