-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for ephemeral sessions [SDK-1559] #388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a lot of refactoring going on for what is basically surfacing this ephemeralSession
flag.
I always try to leave the codebase in a better shape than before. It's better to do that incrementally like this. |
Fix broken link due to renaming introduced on PR auth0#388
Fix broken link due to renaming introduced on PR auth0#388
Changes
useEphemeralSession()
to WebAuth that setsprefersEphemeralWebBrowserSession
totrue
on iOS 13+ and macOS. It has no effect on older versions of iOS. As it depends onprefersEphemeralWebBrowserSession
, this method is only available for Swift 5.1+. Usage of this method disables SSO.WebAuth.swift
toWebAuthenticatable.swift
.Testing
This change was tested manually by performing login and logout on macOS 10.15.4 and iOS simulators 10.3.1, 11.4 and 13.3.
Checklist