Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for ephemeral sessions [SDK-1559] #388

Merged
merged 11 commits into from
May 18, 2020

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented May 8, 2020

Changes

  • Added a new public method useEphemeralSession() to WebAuth that sets prefersEphemeralWebBrowserSession to true on iOS 13+ and macOS. It has no effect on older versions of iOS. As it depends on prefersEphemeralWebBrowserSession, this method is only available for Swift 5.1+. Usage of this method disables SSO.
  • Renamed the file WebAuth.swift to WebAuthenticatable.swift.
  • Renamed a couple of parameters in internal methods.

Testing

This change was tested manually by performing login and logout on macOS 10.15.4 and iOS simulators 10.3.1, 11.4 and 13.3.

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket added this to the vNext milestone May 8, 2020
@Widcket Widcket requested a review from a team May 8, 2020 23:48
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a lot of refactoring going on for what is basically surfacing this ephemeralSession flag.

@Widcket
Copy link
Contributor Author

Widcket commented May 18, 2020

Seems like a lot of refactoring going on for what is basically surfacing this ephemeralSession flag.

I always try to leave the codebase in a better shape than before. It's better to do that incrementally like this.

@Widcket Widcket merged commit 7f1e0a5 into master May 18, 2020
@Widcket Widcket deleted the feature/ephemeral-sessions branch May 18, 2020 16:11
@Widcket Widcket mentioned this pull request May 18, 2020
amadeu01 added a commit to amadeu01/Auth0.swift that referenced this pull request Oct 7, 2020
Fix broken link due to renaming introduced on PR auth0#388
amadeu01 added a commit to amadeu01/Auth0.swift that referenced this pull request Oct 7, 2020
Fix broken link due to renaming introduced on PR auth0#388
@amadeu01 amadeu01 mentioned this pull request Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants