Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move NativeAuth.start() into the NativeAuth protocol declaration #390

Merged
merged 1 commit into from
May 20, 2020

Conversation

ejensen
Copy link
Contributor

@ejensen ejensen commented May 19, 2020

Changes

Moves NativeAuth.start() into the NativeAuth protocol declaration. This allows SDK clients to provide an implementation. Rather than restricting it to the default implementation defined in the protocol extension.

This enables clients to write their own implementation of start. For example, we need to call authentication.login(facebookSessionAccessToken: ...) in our implementation of the protocol, rather than authentication.loginSocial(token:...) that's called by the default protocol extension implementation.

This is a non-breaking change to the protocol.

References

Testing

No additional testing is required since this is an inert change to a protocol

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@ejensen ejensen requested a review from a team May 19, 2020 21:42
@Widcket
Copy link
Contributor

Widcket commented May 20, 2020

@ejensen thanks for the contribution!

@Widcket Widcket merged commit 5d83003 into auth0:master May 20, 2020
@Widcket Widcket added this to the vNext milestone Jun 10, 2020
@Widcket Widcket mentioned this pull request Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants