Sign in with Apple profile parameter #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e) method This enables passing more than just the name of the user
Widcket
added
the
needs investigation
|
Hi @ejensen, apologies for the delay. I'm a little busy right now, so I'll be reviewing this next week. |
Widcket
approved these changes
Jun 8, 2020
Widcket
added
CH: Added
and removed
needs investigation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds an optional
profileparameter to thelogin(appleAuthorizationCode:). This enables passing more profile information than just the name. This supplements the existingfullNameparameter, and follows the same convention as the existinglogin(facebookSessionAccessToken: profile:)method.This is a non-breaking API change since the protocol extension provides a default
nilvalue to the new parameter.Testing
Checklist