Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user property to CredentialsManager [SDK-2633] #482

Merged
merged 3 commits into from
Jul 2, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Jul 2, 2021

Changes

This PR adds the user property to the CredentialsManager that returns the user profile synchronously, without checking if the credentials are expired.
Note that access to this property will not be protected by Biometric Authentication.

References

Fixes #437

Testing

Unit tests have been added, plus it was tested manually with an iOS simulator.

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket requested a review from a team as a code owner July 2, 2021 01:58
@Widcket Widcket changed the title Add user property to CredentialsManager Add user property to CredentialsManager [SDK-2633] Jul 2, 2021
@Widcket Widcket changed the title Add user property to CredentialsManager [SDK-2633] Add user property to CredentialsManager [SDK-2633] Jul 2, 2021
@Widcket Widcket merged commit 5abf186 into master Jul 2, 2021
@Widcket Widcket deleted the feature/user-property branch July 2, 2021 14:35
@Widcket Widcket added this to the vNext milestone Jul 6, 2021
@Widcket Widcket mentioned this pull request Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a synchronous way of retrieving the currently stored Credentials
2 participants