Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use the message from the underlying error #565

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Dec 2, 2021

Changes

This PR changes the error message logic for CredentialsManagerError and AuthenticationError so that it will not automatically return the error message from the underlying error if there is one, because the developer is expected to handle the underlying error anyway, and having both the error and underlying error have the same message could be confusing.

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket requested a review from a team as a code owner December 2, 2021 02:50
@Widcket Widcket added the review:small Small review label Dec 2, 2021
@auth0 auth0 deleted a comment from starman1398 Dec 2, 2021
@Widcket Widcket merged commit b66600e into beta Dec 2, 2021
@Widcket Widcket deleted the v2/error-messages branch December 2, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants