Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make AuthTransaction protocol internal #570

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Make AuthTransaction protocol internal #570

merged 2 commits into from
Dec 6, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Dec 4, 2021

Changes

⚠️ THIS PR CONTAINS BREAKING CHANGES

This PR changes the AuthTransaction protocol from public to internal, as it is no longer necessary for it to be public. It was public because it was used to compose the NativeAuthTransaction protocol. That protocol was removed, so AuthTransaction can be internal now.

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket requested a review from a team as a code owner December 4, 2021 01:42
@Widcket Widcket changed the base branch from master to beta December 4, 2021 01:42
@Widcket Widcket added the review:tiny Tiny review label Dec 4, 2021
@Widcket Widcket merged commit 66b99f3 into beta Dec 6, 2021
@Widcket Widcket deleted the v2/auth-transaction branch December 6, 2021 12:19
@Widcket Widcket mentioned this pull request Jan 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

Assignees
No one assigned
Labels
review:tiny Tiny review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @adamjmcgrath