Have the revoke() method of the Credentials Manager yield a Result
#582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
force-pushed
the
v2/revoke-result
branch
from
7de34c4
to
faee7c1
Compare
adamjmcgrath
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In v2, all the async methods in the library yield a
Result– except therevoke(headers:callback:)method of the Credentials Manager. This PR updates it to yield aResultas well, for consistency with the rest of the library.Similar examples in Auth0.swift:
revoke(refreshToken:)->Request<Void, AuthenticationError>(which produces aResult<Void, AuthenticationError>)resetPassword(email:connection:)->Request<Void, AuthenticationError>(which produces aResult<Void, AuthenticationError>)Testing
Checklist