Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename createUser to signup #597

Merged
merged 2 commits into from
Dec 17, 2021
Merged

Rename createUser to signup #597

merged 2 commits into from
Dec 17, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Dec 16, 2021

Changes

⚠️ THIS PR CONTAINS BREAKING CHANGES

This PR renames the Authentication client method createUser() to signup(), which is more aligned with the terminology used across the SDK and its documentation for the signup operation.

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket requested a review from a team as a code owner December 16, 2021 16:05
@Widcket Widcket added the review:small Small review label Dec 16, 2021
@Widcket Widcket merged commit 5c59556 into beta Dec 17, 2021
@Widcket Widcket deleted the v2/signup branch December 17, 2021 14:42
@Widcket Widcket mentioned this pull request Jan 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

Assignees
No one assigned
Labels
review:small Small review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @adamjmcgrath