Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make UserPatchAttributes class final #611

Merged
merged 1 commit into from
Dec 22, 2021
Merged

Make UserPatchAttributes class final #611

merged 1 commit into from
Dec 22, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Dec 22, 2021

Changes

⚠️ THIS PR CONTAINS BREAKING CHANGES

This PR marks the UserPatchAttributes class as final since it will never have to be subclassed.

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket requested a review from a team as a code owner December 22, 2021 06:09
@Widcket Widcket added the review:tiny Tiny review label Dec 22, 2021
@Widcket Widcket merged commit 33a4185 into beta Dec 22, 2021
@Widcket Widcket deleted the v2/final-userpatchattributes branch December 22, 2021 15:41
@Widcket Widcket mentioned this pull request Jan 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

Assignees
No one assigned
Labels
review:tiny Tiny review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @adamjmcgrath