Send GET request parameters as query params [SDK-3324] #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ Changes
Currently, Auth0.swift’s
Requestwill send all parameters in the request body. This is not correct for Authentication API GET requests like/userinforequests. Therefore requests to/userinfothat include custom parameters will fail.The Android SDK handles this case correctly, by sending the parameters as query params:
This bug was found while doing manual testing for the upcoming Flutter SDK.
This PR fixes the bug by sending the GET request parameters as query params. The changes are unit-tested, and were manually tested as well.
✅ Checklist