Add new error type to AuthenticationError #820
Merged
+19
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordzsolt
changed the title
Widcket
reviewed
Jan 4, 2024
| let error = AuthenticationError(info: values, statusCode: 403) | ||
| expect(error.isInvalidRefreshToken) == true | ||
| } | ||
|
|
There was a problem hiding this comment.
Please update the "should not match any custom error" and "should not match any known error" test cases as well.
There was a problem hiding this comment.
Thanks for the quick review! Updated.
Widcket
requested changes
Jan 4, 2024
There was a problem hiding this comment.
Thanks @lordzsolt for the contribution! Please address the requested change and it should be ready to merge.
Widcket
previously approved these changes
Jan 4, 2024
Widcket
reviewed
Jan 4, 2024
Widcket
reviewed
Jan 4, 2024
Widcket
approved these changes
Jan 4, 2024
Merged
|
This is now out in v2.6.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
This PR adds new error types to AuthenticationError to match those in Auth0.Android:
isInvalidRefreshToken📎 References
🎯 Testing
Test was added according to existing test specs.