Native Authentication support #86

cocojoe · 2017-01-30T12:54:08Z

Adds support for native authentication with a third party IdP using their iOS SDK and then performing the Auth against Auth0.

hzalaz · 2017-01-30T15:00:06Z

Auth0.podspec

@@ -21,9 +21,9 @@ Pod::Spec.new do |s|
  s.ios.source_files = 'Auth0/*.{swift,h,m}'
  s.ios.frameworks = 'UIKit', 'SafariServices'
  s.osx.source_files = 'Auth0/*.swift'
-  s.osx.exclude_files = 'Auth0/_ObjectiveWebAuth.swift', 'Auth0/ControllerModalPresenter.swift', 'Auth0/OAuth2Grant.swift', 'Auth0/OAuth2Session.swift', 'Auth0/SessionStorage.swift', 'Auth0/WebAuth.swift', 'Auth0/WebAuthError.swift', 'Auth0/SafariWebAuth.swift'
+  s.osx.exclude_files = 'Auth0/_ObjectiveWebAuth.swift', 'Auth0/ControllerModalPresenter.swift', 'Auth0/OAuth2Grant.swift', 'Auth0/AuthTransaction.swift', 'Auth0/TransactionStore.swift', 'Auth0/WebAuth.swift', 'Auth0/WebAuthError.swift', 'Auth0/SafariWebAuth.swift'


Shouldn't we exclude native auth file?

hzalaz · 2017-01-30T15:00:54Z

Auth0/AuthTransaction.swift

+import SafariServices
+
+/**
+ Represents an on going AuthTransaction with Auth0.


Represents an on going Auth transaction with an Identity Provider (Auth0 or a third party).

hzalaz · 2017-01-30T15:10:09Z

Auth0/AuthTransaction.swift

+/**
+ Represents an on going AuthTransaction with Auth0.
+
+ It will handle result from the redirect URL configured when the AuthTransaction flow was started,


Since the Auth will be done outside the application control, Safari or third party IdP App, the only way to communicate the results back is using an url with a registered custom scheme in our application so iOS can open it on success/failure. When that happens iOS will call a method in your AppDelegate and there is where we need to handle the result.

hzalaz · 2017-01-30T15:10:24Z

Auth0/NativeAuth.swift

+
+import UIKit
+
+public protocol AuthProvider {


hzalaz · 2017-01-30T15:12:08Z

Auth0/NativeAuth.swift

+    let token: String
+    let extras: [String: Any]
+
+    public init(token: String, extras: [String: Any]) {


Make public the attributes instead of creating an init

Thought I had did this for a reason, if you want a public structure type to be initializable with a memberwise initializer when used in another module, you must provide a public memberwise initializer yourself.

unless both attributes are public so it should infer the constructor

It will infer for the project but not when imported. Source

hzalaz · 2017-01-30T15:15:00Z

Auth0/NativeAuth.swift

+        nativeAuthCredentials.extras.forEach { key, value in parameters[key] = value }
+
+        authentication().loginSocial(token: nativeAuthCredentials.token, connection: connection, scope: scope, parameters: parameters)
+            .start { callback($0) }


Just pass the callback as the parameter why wrapping it up in another one?

hzalaz · 2017-01-30T15:15:36Z

Auth0/TransactionStore.swift

-    static let sharedInstance = SessionStorage()
+/// Keeps track of current Auth Transaction
+class TransactionStore {
+    static let sharedInstance = TransactionStore()


Now that we are modifying it let's use the shared name instead

hzalaz · 2017-01-30T15:19:42Z

Auth0/NativeAuth.swift

+    func login(withConnection connection: String, scope: String, parameters: [String: Any]) -> NativeAuthTransaction
+}
+
+public struct NativeAuthCredentials {


hzalaz · 2017-01-30T15:20:15Z

Auth0/NativeAuth.swift

+    func auth(callback: @escaping Callback) -> ()
+}
+
+public extension NativeAuthTransaction {


hzalaz · 2017-01-30T15:20:48Z

Auth0/NativeAuth.swift

@@ -0,0 +1,74 @@
+// NativeAuth.swift


I believe we might need to split the file in parts

I broke out AuthProvider, everything left is NativeAuth*

hzalaz · 2017-01-30T18:13:20Z

Auth0/NativeAuth.swift

+ Scope, connnection and parameters are used in the final stage of Auth Transaction during the Auth0 Social Authentication.
+
+ ```
+ class SocialNativeTransaction: NativeAuthTransaction {


I am not buying this example, it does not explain what each method does and what the parameter are for, what are the properties. Also it is not showing any real case usage.

We need to document each protocol property and method explaining what it does

Have fleshed this out, let's see how it feels.

Rename SessionStorage to TransactionStore, implements AuthStorage Rename OAuth2Session to AuthTransaction Update tests Separate AuthTransaction / SafariSession code Remove session references in TransactionStore

Code Style changes

Improved NativeAuthTransaction tests

hzalaz suggested changes Jan 30, 2017

View reviewed changes

hzalaz force-pushed the api_add_native_authentication branch from e14787f to 03805e1 Compare January 30, 2017 21:17

cocojoe force-pushed the api_add_native_authentication branch from 03805e1 to 1fc08ca Compare January 30, 2017 21:31

cocojoe and others added 3 commits January 30, 2017 19:43

Add NativeAuthentication Protocols / Extension

15191a4

Rename SessionStorage to TransactionStore, implements AuthStorage Rename OAuth2Session to AuthTransaction Update tests Separate AuthTransaction / SafariSession code Remove session references in TransactionStore

Improved Native Authentication Documentation

05f27f6

Code Style changes

Add more docs

33e7482

hzalaz force-pushed the api_add_native_authentication branch from 1fc08ca to 33e7482 Compare January 30, 2017 22:43

hzalaz and others added 2 commits January 30, 2017 19:48

Small lint fix and a bit more docs

ba6990f

Authentication property added to NativeAuthTransaction Protocol

1c7d306

Improved NativeAuthTransaction tests

cocojoe force-pushed the api_add_native_authentication branch from 2b7b65a to 1c7d306 Compare January 31, 2017 13:17

hzalaz added the CH: Added label Jan 31, 2017

hzalaz added this to the v1-Next milestone Jan 31, 2017

hzalaz approved these changes Jan 31, 2017

View reviewed changes

hzalaz changed the title ~~API Native Authentication Protocols~~ Native Authentication support Jan 31, 2017

hzalaz merged commit f3b1b12 into master Jan 31, 2017

hzalaz deleted the api_add_native_authentication branch January 31, 2017 16:12

hzalaz modified the milestones: v1-Next, 1.2.0 Feb 6, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Native Authentication support #86

Native Authentication support #86

cocojoe commented Jan 30, 2017 •

edited by hzalaz

Loading

hzalaz Jan 30, 2017

hzalaz Jan 30, 2017

hzalaz Jan 30, 2017

hzalaz Jan 30, 2017

hzalaz Jan 30, 2017

cocojoe Jan 30, 2017

hzalaz Jan 30, 2017

cocojoe Jan 30, 2017

hzalaz Jan 30, 2017

hzalaz Jan 30, 2017

hzalaz Jan 30, 2017

hzalaz Jan 30, 2017

hzalaz Jan 30, 2017

cocojoe Jan 30, 2017

hzalaz Jan 30, 2017

cocojoe Jan 30, 2017

Native Authentication support #86

Native Authentication support #86

Conversation

cocojoe commented Jan 30, 2017 • edited by hzalaz Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cocojoe commented Jan 30, 2017 •

edited by hzalaz

Loading