instrumentation: add telemetry around failures #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will start collecting errors. We can continue tweaking this, but this will get us to the basics at least. == In scope: - Reporting the Go version - Reporting the OS type - Reproting the architecture (e.g. amd64) == Out of scope: - Discerning the different error types we have. For now, any errors will get sent.
cyx
force-pushed
the
add-instrumentation
branch
from
8b5dea3
to
1b52a14
Compare
jfatta
approved these changes
Mar 27, 2021
I think the best time to do this is during the install. If we can drop a note such as: "By using the auth0 CLI you agree to <...>" -- e.g. classic legalese language. Similarly on the non-brew install options. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will start collecting errors. We can continue tweaking this, but
this will get us to the basics at least.
In scope:
Out of scope:
get sent -- so long as you're using a build that came from one of our future releases (previous releases wouldn't have this of course).
For developers
go install ./cmd/auth0flow. This would skip error reporting since we're not baking the instrumentation related information when we do this (the github action would be the one doing that).