Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for M1 macs #272

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Add support for M1 macs #272

merged 1 commit into from
Apr 30, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Apr 30, 2021

Description

This PR adds arm64 to the goarch list in the Goreleaser config, to support M1 macs and arm Linux.

Screen Shot 2021-04-30 at 15 15 49

References

Fixes #255

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from a team April 30, 2021 18:19
Copy link
Contributor

@jfatta jfatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

should we update the homebrew repo too?

@Widcket Widcket merged commit bf0ed51 into main Apr 30, 2021
@Widcket Widcket deleted the m1-support branch April 30, 2021 18:23
Widcket added a commit that referenced this pull request Apr 30, 2021
Add arm64 to the goarch list (#272)
Widcket added a commit that referenced this pull request Apr 30, 2021
* Fix cursor escape seqs being written to StdOut

* Add arm64 to the goarch list

Add arm64 to the goarch list (#272)
@Widcket
Copy link
Contributor Author

Widcket commented Apr 30, 2021

@jfatta it's not necessary, I think 🤔 what did you have in mind?

@jfatta
Copy link
Contributor

jfatta commented Apr 30, 2021

@jfatta it's not necessary, I think 🤔 what did you have in mind?

@Widcket I guess this here will have a new option poinitng to the right binary (release asset of this repo), but goreleaser should take care of that. Let's see what happens on the next release
https://github.com/auth0/homebrew-auth0-cli/blob/538a8d43f37f0c7e7a147a6762031b88084705c1/auth0.rb#L12-L14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brew install is not working
2 participants