DXCDT-588: Prevent user create or import to continue if connection is disabled #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
commented
Nov 22, 2023
Comment on lines
+679
to
+680
| management.Parameter("strategy[1]", management.ConnectionStrategyEmail), | ||
| management.Parameter("strategy[2]", management.ConnectionStrategySMS), |
There was a problem hiding this comment.
Passwordless connections should have also been allowed.
sergiught
force-pushed
the
DXCDT-588-conn-enabled-user-create
branch
from
7e67225
to
6ad3978
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #921 +/- ##
==========================================
- Coverage 72.46% 72.35% -0.11%
==========================================
Files 92 92
Lines 12462 12484 +22
==========================================
+ Hits 9030 9033 +3
- Misses 2906 2922 +16
- Partials 526 529 +3 ☔ View full report in Codecov by Sentry. |
Widcket
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
When invoking
auth0 users create|importwe make sure the connection is enabled before continuing.📚 References
🔬 Testing
📝 Checklist