[DXEX-629] pages: fix error when dumping error_page without html property #247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ Changes
The
error_page
object in tenant setting may contain only aurl
property for redirection and without ahtml
property for templating. Previously we assumehtml
is always present and thus will attempt to passundefined
as thedata
argument tofs.writeFileSync()
, which now throws error on Node.js 14.This PR fixes this by skipping writing the template file when
error_page
does not have the propertyhtml
. Tests forurl
andshow_log_link
inerror_page
were also added.🔗 References
🎯 Testing
✅ This change has unit test coverage
🚫 This change has integration test coverage
🚫 This change has been tested for performance