Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CI job to ensure code compilation #641

Merged
merged 6 commits into from
Aug 26, 2022

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Aug 26, 2022

✏️ Changes

#639, which should have been a routine dependency dependabot upgrade, led to an eventual build failure when merged into master. The error was due to a stricter rules employed by the Typescript compiler. This build failure was caught in the E2E CLI tests, which build the code, but at no point before then do we check to see if the code compiles. This PR addresses this issue by simply ensuring that the code compiles without generating any artifacts.

Additionally, adding names to some of the other jobs because it looks so much better in the PR view.

🔗 References

🎯 Testing

No functional changes. Confirmed working in CircleCI by pushing a bunk code change and job caught it.

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2022

Codecov Report

Merging #641 (38b025b) into master (0858e5a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #641   +/-   ##
=======================================
  Coverage   83.31%   83.31%           
=======================================
  Files         114      114           
  Lines        3315     3315           
  Branches      611      611           
=======================================
  Hits         2762     2762           
  Misses        323      323           
  Partials      230      230           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@willvedd willvedd marked this pull request as ready for review August 26, 2022 16:18
@willvedd willvedd requested a review from a team as a code owner August 26, 2022 16:18
@willvedd
Copy link
Contributor Author

Note: Github is still checking the old job names, doesn't detect a rename here which actually makes sense, how would it? Will have to override.

@willvedd willvedd merged commit 8d84395 into master Aug 26, 2022
@willvedd willvedd deleted the add-ci-step-typescript-compile branch August 26, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants