Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

af: Fix email verified type #309

Merged
merged 8 commits into from
Nov 1, 2023
Merged

Conversation

itome
Copy link
Contributor

@itome itome commented Oct 3, 2023

email_verified field is sometimes String type instead of bool ("true" instead of true).
I'm not professional on OIDC so I don't know whether it's always String or both String and bool is allowed.

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

Supoprt string type email_verified payload.

📎 References

🎯 Testing

@itome itome requested a review from a team as a code owner October 3, 2023 07:08
@Widcket
Copy link
Contributor

Widcket commented Oct 4, 2023

Hi @itome, thanks for raising this.

Could you please expand on the circumstances where you found email_verified came as a string instead of a bool?

@Widcket Widcket added the more info needed This issue is waiting for more information in order to progress label Oct 4, 2023
@itome
Copy link
Contributor Author

itome commented Oct 10, 2023

@Widcket I found it with apple login. Google login and Twitter login works correct.

Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @itome! Really appreciate the contribution.

@Widcket Widcket removed the more info needed This issue is waiting for more information in order to progress label Oct 20, 2023
@Widcket Widcket closed this Oct 20, 2023
@Widcket Widcket reopened this Oct 20, 2023
@Widcket Widcket temporarily deployed to external October 20, 2023 13:29 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to external October 20, 2023 13:29 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to external October 20, 2023 13:29 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to external October 20, 2023 13:29 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (253209a) 96.08% compared to head (f35ff20) 95.80%.
Report is 15 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #309      +/-   ##
============================================
- Coverage     96.08%   95.80%   -0.29%     
============================================
  Files            97       76      -21     
  Lines          1611     1121     -490     
  Branches        331      281      -50     
============================================
- Hits           1548     1074     -474     
+ Misses           49       46       -3     
+ Partials         14        1      -13     
Flag Coverage Δ
auth0_flutter 100.00% <100.00%> (ø)
auth0_flutter_android ?
auth0_flutter_ios ?
auth0_flutter_platform_interface 87.03% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...lib/src/web/extensions/user_profile_extension.dart 100.00% <100.00%> (ø)
...lutter_platform_interface/lib/src/credentials.dart 100.00% <100.00%> (ø)

... and 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Widcket Widcket linked an issue Oct 20, 2023 that may be closed by this pull request
6 tasks
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itome the new test is failing:

Screenshot 2023-10-20 at 2 38 27 PM

@Widcket Widcket temporarily deployed to external October 27, 2023 17:12 — with GitHub Actions Inactive
@itome itome requested a review from Widcket November 1, 2023 02:24
@itome
Copy link
Contributor Author

itome commented Nov 1, 2023

@Widcket Sorry to be late. I fixed the test.

@Widcket Widcket temporarily deployed to external November 1, 2023 13:59 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to external November 1, 2023 14:41 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to external November 1, 2023 14:41 — with GitHub Actions Inactive
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @itome!

@Widcket Widcket merged commit 9a1e531 into auth0:main Nov 1, 2023
15 checks passed
@itome itome deleted the fix/email-verified-type branch November 1, 2023 23:35
@Widcket Widcket changed the title Fix email verified type af: Fix email verified type Nov 8, 2023
@Widcket Widcket mentioned this pull request Nov 8, 2023
@Widcket
Copy link
Contributor

Widcket commented Nov 9, 2023

This is now out in v1.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashes when using Apple Connection in Web sign in
2 participants