Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing "sources" property to the Permission #254

Merged
merged 3 commits into from
May 18, 2020
Merged

Add missing "sources" property to the Permission #254

merged 3 commits into from
May 18, 2020

Conversation

lbalmaceda
Copy link
Contributor

@lbalmaceda lbalmaceda commented May 12, 2020 •
edited
Loading

Changes

Adds a missing property to the Permission object. Mostly boilerplate code.

References

Closes #246

Testing

I've added missing tests for the Permission and its page object as well.

  • This change adds test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@lbalmaceda lbalmaceda added this to the v1-Next milestone May 12, 2020
@lbalmaceda lbalmaceda requested a review from a team May 12, 2020 18:09
@lbalmaceda lbalmaceda mentioned this pull request May 12, 2020
Closed
lbalmaceda
lbalmaceda commented May 12, 2020
View reviewed changes
src/main/java/com/auth0/json/mgmt/Permission.java
@@ -12,96 +14,109 @@
@JsonInclude(JsonInclude.Include.NON_NULL)
public class Permission {

@JsonProperty("permission_name")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace changes, previous version was not properly formatted. Ignore up until the bottom where a new method is added for "getting the sources"

@adamjmcgrath adamjmcgrath self-requested a review May 18, 2020 12:08
@lbalmaceda lbalmaceda merged commit 79da0ac into master May 18, 2020
@lbalmaceda lbalmaceda deleted the add-persources branch May 18, 2020 19:10
@BLWedge09
Copy link

@lbalmaceda Forgive me for my lack of knowledge on your process, but I see this has now been merged to master. At what point will this be built/released and become available as a jar file from say...Maven?

@lbalmaceda
Copy link
Contributor Author

@BLWedge09 will get released to jcenter and mavencentral before end of week 👍we always give it a few days to fit something else in the release.

@BLWedge09
Copy link

@lbalmaceda Any chance this gets released today?

@lbalmaceda lbalmaceda modified the milestones: v1-Next, 1.17.0 May 22, 2020
@lbalmaceda
Copy link
Contributor Author

It's pending approval. Hopefully by the end of the day.

@lbalmaceda
Copy link
Contributor Author

@BLWedge09 1.17.0 it's already available on JCenter and will hit Central in the next hour.

@BLWedge09
Copy link

@BLWedge09 1.17.0 it's already available on JCenter and will hit Central in the next hour.

Awesome! Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

Assignees
No one assigned
Labels
CH: Added small
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

Add sources to Permission objects returned from ManagementAPI users().listPermissions call
3 participants
@lbalmaceda @BLWedge09 @adamjmcgrath