Skip to content
This repository has been archived by the owner on May 17, 2023. It is now read-only.

DXDP-706: Form.FormGroup will render empty boxes when null are passed as children #1677

Closed
loginist opened this issue Oct 22, 2019 · 2 comments
Labels
🐞bug Bug reports and bug fixes 🎃 hacktoberfest https://hacktoberfest.digitalocean.com

Comments

@loginist
Copy link
Contributor

loginist commented Oct 22, 2019

Actual behavior

<Form.FormGroup>
  <Form> ... </Form> // => going to render a wrapped form
  {null} // => going to render an empty <Well> component
</Form.FormGroup>

Expected behavior

<Form.FormGroup>
  <Form> ... </Form> // => going to render a wrapped form
  {null} // => renders nothing
</Form.FormGroup>

Temporal solution in client side

const CFormGroup = styled(FormGroup)`
	${FormGroup.FormWrapper}:empty {
	  display:none;
	}
`
@loginist loginist added 🎃 hacktoberfest https://hacktoberfest.digitalocean.com 🐞bug Bug reports and bug fixes labels Oct 22, 2019
@vjsolanki
Copy link
Contributor

i would like to work on this.

@loginist
Copy link
Contributor Author

Hey @solankivj94! Thank you for your interest in Cosmos. This task was actually addressed in #1678.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞bug Bug reports and bug fixes 🎃 hacktoberfest https://hacktoberfest.digitalocean.com
Projects
None yet
Development

No branches or pull requests

2 participants