Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on commons-codec. #30

Closed
wants to merge 1 commit into from
Closed

Remove dependency on commons-codec. #30

wants to merge 1 commit into from

Conversation

christopherthielen
Copy link
Contributor

I see there's already some discussion regarding whether or not it's a good idea to keep Jackson as a dependency. Considering it currently is a dependency, however, it's worth noting that Jackson also provides Base64 en/decoding. This PR removes the commons-codec dependency and replaces the en/decode calls with a small Base64 class that delegates to Jackson.

All current tests pass.

I'm packaging and deploying original-java-jwt.jar (no dependencies rolled in via shade) into my app. I don't really want a dependency on commons-codec, thus the motivation for this. It's just a thought 👍

@pose
Copy link
Contributor

pose commented May 13, 2015

Thanks @christopherthielen. We like the idea of replacing codecs dependency but we need to make some checks in order to see if it works as expected.

@pose pose added enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature next-minor labels May 13, 2015
@schmitch
Copy link

Is this really necessary?! I mean Java8 has a Base64 decoder, so basically people could just use it and force a Version which only works on Java8

@sibay
Copy link

sibay commented Nov 4, 2015

i saw this pr too late. i just added a new pr replacing commons-codec and jackson with jdk8 base64 and boon json. Someone should decide what to take.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants