Remove dependency on commons-codec. #30
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see there's already some discussion regarding whether or not it's a good idea to keep Jackson as a dependency. Considering it currently is a dependency, however, it's worth noting that Jackson also provides Base64 en/decoding. This PR removes the commons-codec dependency and replaces the en/decode calls with a small Base64 class that delegates to Jackson.
All current tests pass.
I'm packaging and deploying original-java-jwt.jar (no dependencies rolled in via shade) into my app. I don't really want a dependency on commons-codec, thus the motivation for this. It's just a thought 👍