Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phone_number_input has no validation hint/msg #1836

Closed
blankg opened this issue Mar 26, 2020 · 1 comment · Fixed by #1837
Closed

phone_number_input has no validation hint/msg #1836

blankg opened this issue Mar 26, 2020 · 1 comment · Fixed by #1837
Labels
language file Additions or changes to i18n language files

Comments

@blankg
Copy link
Contributor

blankg commented Mar 26, 2020

Please do not report security vulnerabilities here. The Responsible Disclosure Program details the procedure for disclosing security issues.

Thank you in advance for helping us to improve this library! Please read through the template below and answer all relevant questions. Your additional work here is greatly appreciated and will help us respond as quickly as possible. For general support or usage questions, use the Auth0 Community or Auth0 Support. Finally, to avoid duplicates, please search existing Issues before submitting one here.

By submitting an Issue to this repository, you agree to the terms within the Auth0 Code of Conduct.

Description

When using passwordless login with phone_number_input, if user enters illegal chars (for example +444-5555) there is a client side validation using a numbers only regex. The only indication user has is a red line under the input. We got feedbacks from users they could not understand what is wrong.
A simple invalidhint string with something like "invalid phone number. only numbers are allowed" would make a big difference.

Reproduction

In a passwordless login screen just enter a phone number with invalid chars like +5874-4444 or similar

Environment

"auth0-lock": "11.22.2"

  • Version of this library used:
  • Version of the platform or framework used, if applicable:
  • Other relevant versions (language, server software, OS, browser):
  • Other modules/plugins/libraries that might be involved:
@stevehobbsdev stevehobbsdev added the language file Additions or changes to i18n language files label Mar 31, 2020
@stevehobbsdev
Copy link
Contributor

Thanks @blankg, let's talk about this on the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language file Additions or changes to i18n language files
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants