Add invalidHint to phoneNumberInput (fix issue #1836) #1837
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Please describe both what is changing and why this is important. Include:
This PR should fix the issue described in issue #1836, by adding an invalidHint property the PhoneNumberInput component.
The invalidHint string is taken from phoneNumberInputInvalidHint which is optional (if not provided then this feature takes no effect) and can be provided in the languageDictionary.
for example:
new Auth0LockPasswordless(clientId, domain, { languageDictionary: { phoneNumberInputInvalidHint: "invalid phone number. only numbers are allowed" } });
Note: the phoneNumberInputInvalidHint can also be added to i18n files to make this behaviour default for the PhoneNumberInput.
References
#1836
Please note any links that are not publicly accessible.
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
snapshots updated with invalidHint prop